-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubernetes manifests for Heartbeat #17928
Conversation
Pinging @elastic/uptime (:uptime) |
Pinging @elastic/integrations-platforms (Team:Platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
[WARNING] | ||
======================================= | ||
If you are using Kubernetes 1.7 or earlier: {beatname_uc} uses a hostPath volume to persist internal data, it's located | ||
under /var/lib/{beatname_lc}-data. The manifest uses folder autocreation (`DirectoryOrCreate`), which was introduced in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there is no DirectoryOrCreate
volume in the manifests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 0db39e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@andrewvc PTAL, happy to go over these changes together |
❕ Build Aborted
Expand to view the summary
Build stats
Log outputExpand to view the last 100 lines of log output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add kubernetes manifests for Heartbeat (cherry picked from commit 16759ab)
* Add kubernetes manifests for Heartbeat (cherry picked from commit 16759ab)
* Add kubernetes manifests for Heartbeat
…eat (elastic#20299) * Add kubernetes manifests for Heartbeat (elastic#17928) * Add kubernetes manifests for Heartbeat (cherry picked from commit 8900d6d) * make update * Add ECK notice
What does this PR do?
Add Kubernetes example manifests for Heartbeat, with some examples on how to use autodiscover there.
Related issues
Closes #17752